Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support tensorflow >= 2.11 #210

Merged

Conversation

Shelnutt2
Copy link
Member

@Shelnutt2 Shelnutt2 commented Jul 17, 2023

Update to support tensorflow >= 2.11 by supporting the new legacy package and the new keras.src package.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #31839: TensorflowKerasTileDBModel doesn't load.

@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch from 8237a0e to 142c6e8 Compare July 17, 2023 20:21
@ihnorton
Copy link
Member

Should we pin a minimum version to make sure that this doesn't break with older versions that don't include this change?

@ktsitsi
Copy link
Collaborator

ktsitsi commented Jul 18, 2023

Indeed as @ihnorton pointed out Keras is a dependency of tensorflow which we do not bound. We need to trackdown when did Keras moved these to legacy and which TF version and above introduces this Keras release so we can either require a higher TF version in our setup or restrict it.

@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch 9 times, most recently from f520ae9 to 79e1975 Compare July 22, 2023 11:55
Shelnutt2 and others added 2 commits July 22, 2023 08:06
Update keras.saving for the packages having moved to legacy
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch 3 times, most recently from 1ad92a6 to 5b4f8e5 Compare July 22, 2023 12:45
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch from 5b4f8e5 to 734f8bb Compare July 23, 2023 10:41
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch 5 times, most recently from ed76082 to 791ee23 Compare July 24, 2023 11:34
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch from 791ee23 to aff195f Compare July 24, 2023 12:30
Copy link
Collaborator

@ktsitsi ktsitsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shelnutt2 Shelnutt2 changed the title Update keras.saving for legacy Update to support tensorflow >= 2.11 Jul 24, 2023
@Shelnutt2 Shelnutt2 merged commit a40a555 into master Jul 24, 2023
6 checks passed
@Shelnutt2 Shelnutt2 deleted the sethshelnutt/sc-31839/tensorflowkerastiledbmodel-doesn-t-load branch July 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants