Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the tensorflow version lower than 2.16 #215

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ktsitsi
Copy link
Collaborator

@ktsitsi ktsitsi commented Aug 23, 2024

This PR:

  • Pins the version of TF <2.16
  • Pins the numpy version in notebooks <2.0

Reason:

Tensorflow >=2.16 comes with a default dependency of Keras backend >= 3.0. The latter introduces many changes in its package module, deprecates many modules, changes module paths and generally after some efforts supporting it in an open PR here #214 we were not able to support it with minimal changes in our package. It will require a restructure of our package and a holistic approach which given the current capacity we ll need to revisit it in the near future.

@ktsitsi ktsitsi requested a review from Shelnutt2 August 23, 2024 12:37
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment regarding the reason for the TF pin

@ktsitsi
Copy link
Collaborator Author

ktsitsi commented Aug 26, 2024

Please add a comment regarding the reason for the TF pin

Sure added it in the PR's description.

@ktsitsi ktsitsi merged commit 3b42e5b into master Aug 26, 2024
6 checks passed
@ihnorton ihnorton deleted the kt/pin-tensorflow-version branch August 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants