-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak #151
Merged
Merged
Fix memory leak #151
Commits on May 17, 2019
-
Fix memory leak due to ignored constructor flag
Fixes #150 PyArray_NewFromDescr ignores the NPY_ARRAY_OWNDATA flag, so we need to set it manually so that NumPy frees the memory. Because we now don't (can't) set the flag in this call, simplify construction by using PyArray_SimpleNewFromData. Now that memory is being freed correctly, we must use the NumPy allocator (PyDataMem_NEW/FREE) so that de-allocation is matched.
Configuration menu - View commit details
-
Copy full SHA for 42cb0a3 - Browse repository at this point
Copy the full SHA 42cb0a3View commit details -
- we can't return the result of KV.create, because then the array will be left in read mode. - writes and reads must happen in separate Ctx to avoid hang
Configuration menu - View commit details
-
Copy full SHA for 041be50 - Browse repository at this point
Copy the full SHA 041be50View commit details -
Configuration menu - View commit details
-
Copy full SHA for f750453 - Browse repository at this point
Copy the full SHA f750453View commit details -
Fix hang due to missing clean-up in exception path
Must close and free before raising the error here.
Configuration menu - View commit details
-
Copy full SHA for 068dc28 - Browse repository at this point
Copy the full SHA 068dc28View commit details -
Fix varlen tests on older NumPy versions.
Older NumPy versions don't respect NPY_ENSURECOPY in some circumstances, which means that the data in the varlen result array is no longer valid after the underlying buffer is freed.
Configuration menu - View commit details
-
Copy full SHA for b099a9d - Browse repository at this point
Copy the full SHA b099a9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b1b1b4 - Browse repository at this point
Copy the full SHA 7b1b1b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd9576b - Browse repository at this point
Copy the full SHA fd9576bView commit details -
- Add psutil install on azure - Fix file deletion on windows
Configuration menu - View commit details
-
Copy full SHA for f67d094 - Browse repository at this point
Copy the full SHA f67d094View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.