Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak #151

Merged
merged 8 commits into from
May 17, 2019
Merged

Fix memory leak #151

merged 8 commits into from
May 17, 2019

Commits on May 17, 2019

  1. Fix memory leak due to ignored constructor flag 

    Fixes #150

PyArray_NewFromDescr ignores the NPY_ARRAY_OWNDATA flag, so we
need to set it manually so that NumPy frees the memory.

Because we now don't (can't) set the flag in this call, simplify
construction by using PyArray_SimpleNewFromData.

Now that memory is being freed correctly, we must use the NumPy
allocator (PyDataMem_NEW/FREE) so that de-allocation is matched.
    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    42cb0a3 View commit details
    Browse the repository at this point in the history

  2. Fix KV tests 

    - we can't return the result of KV.create, because then the
  array will be left in read mode.
- writes and reads must happen in separate Ctx to avoid hang
    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    041be50 View commit details
    Browse the repository at this point in the history

  3. Add missing ctx argument to several constructors in tests

    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    f750453 View commit details
    Browse the repository at this point in the history

  4. Fix hang due to missing clean-up in exception path 

    Must close and free before raising the error here.
    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    068dc28 View commit details
    Browse the repository at this point in the history

  5. Fix varlen tests on older NumPy versions. 

    Older NumPy versions don't respect NPY_ENSURECOPY in some
circumstances, which means that the data in the varlen result
array is no longer valid after the underlying buffer is freed.
    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    b099a9d View commit details
    Browse the repository at this point in the history

  6. Add read buffer memory sanity check 

    ref #150
    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    7b1b1b4 View commit details
    Browse the repository at this point in the history

  7. Target TileDB 1.5.1

    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    fd9576b View commit details
    Browse the repository at this point in the history

  8. Fixes for CI build 

    - Add psutil install on azure
- Fix file deletion on windows
    @ihnorton
    ihnorton committed May 17, 2019
    Configuration menu
    Copy the full SHA
    f67d094 View commit details
    Browse the repository at this point in the history