Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CtxMixin classmethods #1555

Merged
merged 3 commits into from
Jan 12, 2023
Merged

CtxMixin classmethods #1555

merged 3 commits into from
Jan 12, 2023

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Jan 9, 2023

Replace "private" constructor parameters (_capsule, _lt_obv) with CtxMixin classmethods (from_capsule, from_pybind11).Follow-up to #1548.

@gsakkis gsakkis requested review from ihnorton and nguyenv January 9, 2023 10:01
Base automatically changed from gsa/ctx-mixin to dev January 11, 2023 19:21
ihnorton
ihnorton approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will let you rebase (not sure where this branched from the last one)

@gsakkis gsakkis force-pushed the gsa/refactor_lt_obj_capsule branch from 974ccbf to 7dbc9e7 Compare January 11, 2023 21:28
@ihnorton ihnorton merged commit 79ec039 into dev Jan 12, 2023
@ihnorton ihnorton deleted the gsa/refactor_lt_obj_capsule branch January 12, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@nguyenv nguyenv Awaiting requested review from nguyenv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsakkis @ihnorton