Handle empty string passed to Query condition #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #29592: Handle empty string from user in query conditions. |
Shelnutt2
force-pushed
the
sethshelnutt/sc-29592/handle-empty-string-from-user-in-query-conditions
branch
2 times, most recently
from
9aebd77
to
f8a16cd
Compare
|
I am still seeing |
This treats an empty string `""` the same as None when applying a query condition. This is useful as users are passing strings for query condition and avoids the user needing to validate they've successfully built a condition before passing it in.
Shelnutt2
force-pushed
the
sethshelnutt/sc-29592/handle-empty-string-from-user-in-query-conditions
branch
from
f8a16cd
to
5e2eb14
Compare
nguyenv
approved these changes
May 26, 2023
Shelnutt2
deleted the
sethshelnutt/sc-29592/handle-empty-string-from-user-in-query-conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats an empty string
""the same as None when applying a query condition. This is useful as users are passing strings for query condition and avoids the user needing to validate they've successfully built a condition before passing it in.