Remove deprecated Array.delete_fragments code path.
#2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Jul 17, 2024
| timestamp_start, | ||
| timestamp_end | ||
| ) | ||
| # TODO: Make this method static and entirely remove the conditional. |
teo-tsirpanis
commented
Jul 24, 2024
kounelisagis
force-pushed
the
teo/delete-fragments
branch
from
22b26c7
to
7285871
Compare
kounelisagis
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-51240
The
tiledb_array_delete_fragmentsAPI has been removed and this PR removes its last use in the Python API. CallingArray.delete_fragmentsas an instance method will now throw.Fixes TileDB-Inc/conda-forge-nightly-controller#108 (comment)
You might want to snap a branch for the Python API with 2.25 before merging this.