Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clang-format to 18 #2039

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Update clang-format to 18 #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5ea34c
Add pre-commit hook for clang-format
kounelisagis Aug 16, 2024
1aac454
Format code using the new clang-format version
kounelisagis Aug 16, 2024
10a8ebf
Add .git-blame-ignore-revs to exclude previous commit from git blame
kounelisagis Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .git-blame-ignore-revs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# .git-blame-ignore-revs
# Format code using the new clang-format version
1aac45490f8192cded9e3656a215935c92f331fa
6 changes: 0 additions & 6 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,3 @@ jobs:

- name: Run pre-commit hooks on all files
run: python -m pip -v install pre-commit && pre-commit run -a -v

- name: Check formatting (linux only)'
run: |
source $GITHUB_WORKSPACE/ci/scripts/check_formatting_linux.sh
shell: bash
if: ${{ runner.os == 'Linux' }}
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,10 @@ repos:
rev: v0.4.4
hooks:
- id: ruff
- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v18.1.8
hooks:
- id: clang-format
args: ["-style=file"]
types_or: [c, c++]
files: tiledb/
38 changes: 0 additions & 38 deletions ci/scripts/check_formatting_linux.sh
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions ci/scripts/install-clangformat.sh
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions ci/scripts/run-clang-format.sh
View file
Open in desktop

This file was deleted.

Loading
Loading