Default ctx initialization improvements, and custom buffer size #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
changed the title
Allows per-process global config options to be controlled by user.
ihnorton
force-pushed
the
ihn/init_size_cfg
branch
from
bf690ab to
5854a9e
Compare
ihnorton
commented
Jan 3, 2020
| config = tiledb.Config({'sm.memory_budget': 2 * 1024**2}) | ||
| # create context with 1 MB memory budget (2 MB total, 1 MB usable) | ||
| config = tiledb.Config({'sm.memory_budget': 2 * 1024**2, | ||
| 'py.init_buffer_bytes': 1024**2 }) |
There was a problem hiding this comment.
@stavrospapadopoulos do you foresee any problem with putting a custom value in the Config object, in order to maintain a consistent API? Seems to work... (alternatively, could have a separate py_config object)
Shelnutt2
approved these changes
Jan 3, 2020
yes |
ihnorton
force-pushed
the
ihn/init_size_cfg
branch
2 times, most recently
from
4919e88 to
cf0ea27
Compare
(see detailed explanation in code comment)
ihnorton
force-pushed
the
ihn/init_size_cfg
branch
from
cf0ea27 to
5425062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_ctxlazily, allowing user control over global per-process settings when necessary (e.g.sm.num_tbb_threads)default_ctxmay be initialized with custom settings by callingtiledb.libtiledb.initialize_ctx()tiledb.Ctx(...)should specify number of threads (if needed) whenever called before an implicit call todefault_ctx()(unlikely)default_ctxa delayed call in all method definitionspy.init_buffer_bytesparameter