Deprecate Partial Vacuuming #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #15092: Deprecate Partial Vacuuming. |
nguyenv
commented
Feb 25, 2022
nguyenv
changed the title
ihnorton
requested changes
Feb 28, 2022
There was a problem hiding this comment.
IIUC, this change was implemented in core by TileDB-Inc/TileDB#2909
That PR will not be backported, so this functionality will still be available in 0.13 / libtiledb 2.7. So I think we should keep the functionality in place with the deprecation warning (it looks like this PR replaces the functionality with a warning?)
Also needs rebase.
nguyenv
force-pushed
the
viviannguyen/sc-15092/deprecate-partial-vacuuming
branch
from
91a34fd
to
72a9062
Compare
ihnorton
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.