Visualization of a SAR image as a ground surface added #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanb
reviewed
Apr 7, 2022
pybabylonjs/babylonjs.py
Outdated
| @@ -68,6 +68,8 @@ def set_defaults(validator, properties, instance, schema): | |||
|
|
|||
| mbrs_schema = deepcopy(core_schema) | |||
|
|
|||
| ground_schema = {"type": "object"} | |||
There was a problem hiding this comment.
Can you expand this and add the JSON schema elements?
There was a problem hiding this comment.
done, this is now as the below. Also added image_type to be able to add different types of data later.
ground_schema = {
"type": "object",
"properties": {
"inspector": {"type": "boolean", "default": False},
"image_type": {"type": "string", "default": "general"},
"width": {"type": "number", "default": 800},
"height": {"type": "number", "default": 600},
"z_scale": {"type": "number", "default": 1},
"wheel_precision": {"type": "number", "default": -1},
"xy_bbox": {"type": "array", "default": [0, 1, 0, 1]},
"band": {"type": "number", "default": 1},
"scale_factor": {"type": "number", "default": 1},
"img_width": {"type": "number"},
"img_height": {"type": "number"},
},
"required": ["xy_bbox", "img_width"],
}
pybabylonjs/data.py
Outdated
| io_buf = io.BytesIO(buffer) | ||
| return io_buf.read() | ||
|
|
||
| bbox = kwargs["bbox"] |
There was a problem hiding this comment.
These should be marked as required in the ground schema
There was a problem hiding this comment.
I added this, see the schema above
pybabylonjs/data.py
Outdated
| with tiledb.open(array_uri, "r") as arr: | ||
| img = arr[nr, bbox[0] : bbox[1], bbox[2] : bbox[3]][kwargs["attribute"]] | ||
|
|
||
| img_norm = 20 * np.log10(img * kwargs["scale_factor"]) |
There was a problem hiding this comment.
This scaling is specific to this SAR image, can we rename the function?
There was a problem hiding this comment.
Solved this by adding a parameter image_type that only does this conversion when image_type == "sar"
Renamed scale_factor to sar_scale_factor to make this clearer as well
| @@ -260,16 +261,16 @@ export class BabylonMBRSView extends BabylonBaseView { | |||
| const maxz = extents[5]; | |||
|
|
|||
| const scale = this.zScale; | |||
|
|
|||
normanb
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of this type of image, which uses a blob to be able to display the data. This PR will make it possible to test this on TileDB Cloud in the next deployment.
Example API call to create this new visualization: