-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mg/mapbox base layer #29
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3ddd180
renamed visualize.py
MargrietGroenendijk a451387
refactored show.py
MargrietGroenendijk 9d5f53b
mapbox image backup
MargrietGroenendijk e83d867
Update widget.ts
MargrietGroenendijk 0272e0b
mapbox base layer added to point cloud
MargrietGroenendijk 1d57c2a
extended mapbox api call
MargrietGroenendijk e345c39
Update data.py
MargrietGroenendijk 57ed76d
Merge pull request #30 from TileDB-Inc/mg/refactor-ts-classes
MargrietGroenendijk b1e501b
removed print statements
MargrietGroenendijk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
# Copyright 2022 TileDB Inc. | ||
# Licensed under the MIT License. | ||
"""Classes for setting up the visualization.""" | ||
|
||
from IPython.display import display | ||
from typing import Optional | ||
|
||
from .babylonjs import BabylonPointCloud, BabylonMBRS, BabylonImage | ||
from .data import * | ||
|
||
|
||
def create_dataviz(dataviz, d, **kwargs): | ||
dataviz.value = {**d, **kwargs} | ||
display(dataviz) | ||
|
||
|
||
class PyBabylonJSError(Exception): | ||
pass | ||
|
||
|
||
class Show: | ||
"""Create a N-D visualization. | ||
|
||
Parameters: | ||
... | ||
""" | ||
|
||
def __init__(self): | ||
self._value = None | ||
self._dataviz = None | ||
|
||
@classmethod | ||
def point_cloud( | ||
self, | ||
data: dict, | ||
time: Optional[bool] = False, | ||
classes: Optional[bool] = False, | ||
topo: Optional[bool] = False, | ||
**kwargs, | ||
): | ||
d = {"classes": classes, "time": time, "topo": topo, "data": data} | ||
if topo: | ||
img = create_mapbox_image(data, **kwargs) | ||
d = {**d, "mapbox_img": img} | ||
create_dataviz(BabylonPointCloud(), d, **kwargs) | ||
|
||
@classmethod | ||
def image( | ||
self, | ||
array_uri: str, | ||
**kwargs, | ||
): | ||
d = create_image(array_uri, **kwargs) | ||
create_dataviz(BabylonImage(), d, **kwargs) | ||
|
||
@classmethod | ||
def mbrs( | ||
self, | ||
array_uri: str, | ||
**kwargs, | ||
): | ||
d = create_mbrs(array_uri) | ||
create_dataviz(BabylonMBRS(), d, **kwargs) | ||
|
||
@classmethod | ||
def from_dict( | ||
self, | ||
data: dict, | ||
time: Optional[bool] = False, | ||
classes: Optional[bool] = False, | ||
topo: Optional[bool] = False, | ||
**kwargs, | ||
): | ||
d = {"classes": classes, "time": time, "topo": topo, "data": data} | ||
if topo: | ||
img = create_mapbox_image(data, **kwargs) | ||
d = {**d, "mapbox_img": img} | ||
create_dataviz(BabylonPointCloud(), d, **kwargs) | ||
|
||
|
||
class BabylonJS: | ||
"""Legacy class for instantiating the widget""" | ||
|
||
def __init__(self): | ||
self.value = None | ||
self.z_scale = None | ||
self.width = None | ||
self.height = None | ||
|
||
def _ipython_display_(self): | ||
kwargs = {} | ||
|
||
if self.z_scale: | ||
kwargs["z_scale"] = self.z_scale | ||
|
||
if self.width: | ||
kwargs["width"] = self.width | ||
|
||
if self.height: | ||
kwargs["height"] = self.height | ||
|
||
d = {"data": self.value} | ||
create_dataviz(BabylonPointCloud(), d, **kwargs) |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be doing this loading inside of the Typescript widget and use https://doc.babylonjs.com/divingDeeper/importers/assetManager Now we have multiple loading tasks (e.g GLTF) this will help and give display feedback to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but probably not in this PR?