Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api redesign #31

Merged
merged 4 commits into from
Jun 20, 2022
Merged

api redesign #31

merged 4 commits into from
Jun 20, 2022

Conversation

MargrietGroenendijk
Copy link
Contributor

No description provided.

Copy link
Contributor

@normanb normanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have made some general comments.

pybabylonjs/args.py Show resolved Hide resolved
pybabylonjs/args.py Outdated Show resolved Hide resolved
pybabylonjs/args.py Show resolved Hide resolved
pybabylonjs/data.py Show resolved Hide resolved
src/widget.ts Outdated Show resolved Hide resolved
src/widget.ts Outdated Show resolved Hide resolved
src/widget.ts Outdated Show resolved Hide resolved
pybabylonjs/show.py Outdated Show resolved Hide resolved
@MargrietGroenendijk MargrietGroenendijk marked this pull request as ready for review June 9, 2022 18:25
@MargrietGroenendijk MargrietGroenendijk merged commit e05c947 into main Jun 20, 2022
@MargrietGroenendijk MargrietGroenendijk deleted the mg/api-redesign branch July 11, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants