Update nanoarrow and expand use #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgrind clean when no dictionaries are used
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #41534: Refactor to make use of |
awenocur
reviewed
Feb 22, 2024
awenocur
reviewed
Feb 22, 2024
awenocur
reviewed
Feb 22, 2024
awenocur
reviewed
Feb 22, 2024
awenocur
approved these changes
Feb 22, 2024
mojaveazure
approved these changes
Feb 22, 2024
This was referenced Mar 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the vendored
nanoarrowto its recent 0.4.0 release, which includes a rewritten header for R as well as a new C++ header.These are use in a rewritten (main) access (from
tiledb_array) code path now returning a propernanoarrowobject. This is not user-visible: the change affects chiefly what intermediate object is then turned into an Arrow Table object. (We could also return to exporting ananoarrowobject directly as have in the past.)There are additional optimisations to be had. The arrow allocation can/should happen before the query object is created. This is left for another PR. Some older code paths still use a more homegrown set of functions, while they are part of the package (and exported / tested) they are not widely used so this to is left for another (non-urgent) PR.
But relying more completely on
nanoarrowthe export is now more robust and performant. Note that the PR was open and active for a few days, the actions tab shows earlier builds -- but because of a rebase this now looks new.