Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure and Makevars.in #680

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Update configure and Makevars.in #680

merged 2 commits into from
Mar 22, 2024

Conversation

eddelbuettel
Copy link
Contributor

This is a very minor repo and package hygiene update which addresses a few very minor warts I noticed when looking at the configure script for another issue:

  • the version displayed was still stuck at 0.24.0
  • the configure and Makevars.in set the min. compilation version for macOS for x86_64 only, it is the same for both now
    • we could get away with not setting it
    • but then CI would be different from CRAN builds so may as well set
  • one dated version comparison was corrected
  • minor typo in comments in one file

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #43614: Polish for configure.

@eddelbuettel eddelbuettel merged commit 9560ade into master Mar 22, 2024
1 check passed
@eddelbuettel eddelbuettel deleted the de/sc-43614/configure_polish branch March 22, 2024 18:08
@eddelbuettel eddelbuettel mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awenocur awenocur awenocur approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @awenocur