Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate tiledb_query_submit_async() #694

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Deprecate tiledb_query_submit_async() #694

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2bb1d9
Deprecate tiledb_query_submit_async()
eddelbuettel Apr 15, 2024
63ef6ae
Update NEWS and roll micro release [ci skip]
eddelbuettel Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion R/Query.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,9 @@ tiledb_query_submit <- function(query) {
#' @return The modified query object, invisibly
#' @export
tiledb_query_submit_async <- function(query) {
stopifnot(`Argument 'query' must be a tiledb_query object` = is(query, "tiledb_query"))
stopifnot("Argument 'query' must be a tiledb_query object" = is(query, "tiledb_query"))
## Deprecated April 2024, to be removed April 2025 or later
.Deprecated(msg="tiledb_query_submit_async() is deprecated, use tiledb_query_submit() instead.")
libtiledb_query_submit_async(query@ptr)
invisible(query)
}
Expand Down
11 changes: 10 additions & 1 deletion src/deprecation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// MIT License
//
// Copyright (c) 2017-2023 TileDB Inc.
// Copyright (c) 2017-2024 TileDB Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -227,3 +227,12 @@ XPtr<tiledb::Query> libtiledb_query_add_range(XPtr<tiledb::Query> query, int iid
}
return query;
}

// Deprecated in Core April 2024
// [[Rcpp::export]]
XPtr<tiledb::Query> libtiledb_query_submit_async(XPtr<tiledb::Query> query) {
check_xptr_tag<tiledb::Query>(query);
spdl::trace("[libtiledb_query_submit_async]");
query->submit_async();
return query;
}
8 changes: 0 additions & 8 deletions src/libtiledb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3560,14 +3560,6 @@ XPtr<tiledb::Query> libtiledb_query_submit(XPtr<tiledb::Query> query) {
return query;
}

// [[Rcpp::export]]
XPtr<tiledb::Query> libtiledb_query_submit_async(XPtr<tiledb::Query> query) {
check_xptr_tag<tiledb::Query>(query);
spdl::trace("[libtiledb_query_submit_async]");
query->submit_async();
return query;
}

// [[Rcpp::export]]
XPtr<tiledb::Query> libtiledb_query_finalize(XPtr<tiledb::Query> query) {
check_xptr_tag<tiledb::Query>(query);
Expand Down
Loading