Add favicon support in pkgdown via initial man/figure/logo.png #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awenocur
approved these changes
Jul 26, 2024
eddelbuettel
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussing in slack card and favicon support via
pkgdownis possible if one supplies a logo.png inman/figures/. I used the standard TileDB favicon of a blue '[t]' for. This PR enables this, no other changes.However, when previewing it also becomes apparent that the logo would then be added to each generated html page -- not cool as the '[t]' is not our logo. The pages also simply did not look good that way.
So I tricked it: removed the logo, but retained the generated favicons. Now the browser still gets favicons (as confirmed in local rendering, see screeshot with favicons on the two tabs) and the landing page still has our logo (supplied via the authors field) as shown.