Add wrapper for vfs_copy_dir() function
#804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvigilante
force-pushed
the
nv/add-tiledb_vfs_copy_dir
branch
from
0379527 to
56c62f1
Compare
jdblischak
reviewed
Feb 13, 2025
johnkerl
reviewed
Feb 13, 2025
nickvigilante
force-pushed
the
nv/add-tiledb_vfs_copy_dir
branch
from
56c62f1 to
9fa5746
Compare
johnkerl
changed the title
vfs_copy_dir() function
nickvigilante
force-pushed
the
nv/add-tiledb_vfs_copy_dir
branch
2 times, most recently
from
4ab2f8f to
5cbca18
Compare
nickvigilante
force-pushed
the
nv/add-tiledb_vfs_copy_dir
branch
2 times, most recently
from
63ea055 to
67af183
Compare
mojaveazure
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
LGTM, thanks for adding! Please bump the develop version in DESCRIPTION (as of writing, should bump to 0.31.0.2) and add a changelog item to NEWS.md before merging
johnkerl
approved these changes
Feb 13, 2025
I noticed this function was missing when writing up a tutorial on VFS, so this is my attempt at wrapping it.
nickvigilante
force-pushed
the
nv/add-tiledb_vfs_copy_dir
branch
from
67af183 to
b99a559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this function was missing when writing up a tutorial on VFS, so this is my attempt at wrapping it.