-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add initial build wheels CI/CD pipeline #763
base: main
Are you sure you want to change the base?
Conversation
Once this is implemented, this will fix Issue #717 |
Right now I was able to produce wheels in this workflow: Next steps:
|
@@ -72,11 +73,6 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
with: | |||
fetch-depth: 0 # fetch everything for python setuptools_scm | |||
- name: Download libtiledbvcf artifact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step shouldn't be removed. The whole point of this python
job that depends on the previous libtiledbvcf
job is to test that python can be built against an existing libtiledbvcf. The job python-standalone
below already tests the ability of Python to bootstrap a libtiledbvcf installation. We want to test that this continues to work (since it is required eg for our conda feedstock builds).
Latest error that we have face right now is that Windows wheels fail in tests: https://github.com/dudoslav/TileDB-VCF/actions/runs/11348652284/job/31562931109
|
This PR aims to modify the build system for the VCF project to comply with our packaging and distribution guidelines:
https://www.notion.so/Packaging-and-Distribution-96af10190b4f455f9a31180899f47a83?pvs=4
Specifically we want to enable these scenarios:
How to achieve this:
-DTILEDBVCF_ENABLE_PYTHON
option. When this is set libtiledbvcf AND bindings are build otherwise just libtiledbvcf is build. This is used for PyPI package (python bindings enabled) and for libtiledbvcf conda package (python bindings disabled)pyproject.toml
out ofapis/python
to top level of the project.NOTE: This PR is being tested in my personal fork.
--
[sc-54633]