Draft: VCPKG rework #781
Draft: VCPKG rework #781
Conversation
This matches the Core and libtiledbsoma. In particular we need at least 3.15 because of a policy that picks the correct CRT linkage on Windows. Also recent CMake versions will warn if the version is set to earlier than 3.10. With this, `tiledbvcf-bin` compiles and links successfully on Windows.
| RUNTIME DESTINATION tiledbvcf | ||
| LIBRARY DESTINATION tiledbvcf/lib |
There was a problem hiding this comment.
We should be using bin and lib.
There was a problem hiding this comment.
CMAKE_INSTALL_{BINDIR,LIBDIR} for full windows compatibility? https://github.com/TileDB-Inc/TileDB/blob/738f238d99776e03d2eb36ddf0cd55254f9ba32f/tiledb/CMakeLists.txt#L852
There was a problem hiding this comment.
Definitely, after the SEGFAULT is fixed I'll clean up the changes to be more organized and use CMAKE_* variables
There was a problem hiding this comment.
This is kind of an issue, since CMAKE_INSTALL_LIBDIR points to site-packages/lib which is not correct for our case. Looking at other projects they also use just folder names: https://github.com/ssciwr/clang-format-wheel/blob/dc29f5e2a074dee8e862eb29fd0de1d84f41707a/CMakeLists.txt#L43
I don't think that we need to use GNUInstallDirs CMake module. However, perhaps this will come into play when I'll be testing Conda packaging.
UNDER DEVELOPMENT