-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly CI which runs sanitizers #476
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2beee8b
Add nightly CI which runs sanitizers
jparismorgan 2867697
add more sanitizers
jparismorgan 05dc0bd
update
jparismorgan e644673
add more continue
jparismorgan 26f5c71
prepare for merge
jparismorgan 20884f9
fix accuracy issue
jparismorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Nightly | ||
|
||
on: | ||
schedule: | ||
- cron: "0 0 * * *" | ||
# Comment this back in to test file updates. | ||
# pull_request: | ||
# branches: [main] | ||
|
||
jobs: | ||
sanitizer: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
sanitizer: [address, leak, thread] | ||
continue-on-error: true | ||
steps: | ||
- name: Install OpenBLAS | ||
if: ${{ runner.os == 'Linux' }} | ||
run: sudo apt install libopenblas-dev | ||
- uses: actions/checkout@v3 | ||
- name: Configure CMake | ||
run: cmake -S ./src -B ./src/build -DCMAKE_BUILD_TYPE=Debug -DTILEDB_SANITIZER=${{ matrix.sanitizer }} -DTILEDB_VS_ENABLE_BLAS=ON | ||
- name: Build | ||
run: cmake --build ./src/build -j3 | ||
- name: Run Tests | ||
run: cmake --build ./src/build --target check-ci | ||
# TODO: Once we fix sanitizer errors, remove this. | ||
continue-on-error: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you change this value in this PR? I don't think that we should make this accuracy bound that tight. Maybe we can make it
0.8
and avoid test flakiness.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed it b/c a test failed b/c of this flakiness - going to merge this to keep moving, but if I see it (or others) fail again I'll make them a bit looser to prevent more flakiness, good call.