Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IVF_PQ backwards compatibility data generation and testing #555

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jparismorgan
Copy link
Collaborator

What

Add IVF_PQ backwards compatibility data generation and testing.

Testing

Can generate:

(TileDB-Vector-Search-3) ~/repo/TileDB-Vector-Search-3 python backwards-compatibility-data/generate_data.py 0.20.0
/opt/homebrew/anaconda3/envs/TileDB-Vector-Search-3/lib/python3.9/site-packages/tiledb/vector_search/ivf_pq_index.py:198: UserWarning: The IVF PQ index is not yet supported, please use with caution.
  warnings.warn("The IVF PQ index is not yet supported, please use with caution.")
/opt/homebrew/anaconda3/envs/TileDB-Vector-Search-3/lib/python3.9/site-packages/tiledb/vector_search/ivf_pq_index.py:149: UserWarning: The IVF PQ index is not yet supported, please use with caution.
  warnings.warn("The IVF PQ index is not yet supported, please use with caution.")
false

And python tests pass:

(TileDB-Vector-Search-3) ~/repo/TileDB-Vector-Search-3 pytest apis/python/test/test_backwards_compatibility.py -s                  

============================================= test session starts =============================================
platform darwin -- Python 3.9.18, pytest-7.4.3, pluggy-1.3.0
rootdir: /Users/parismorgan/repo/TileDB-Vector-Search-3
collected 1 item                                                                                              

apis/python/test/test_backwards_compatibility.py .

============================================== warnings summary ===============================================
apis/python/test/test_backwards_compatibility.py::test_query_old_indices
  /opt/homebrew/anaconda3/envs/TileDB-Vector-Search-3/lib/python3.9/site-packages/tiledb/vector_search/ivf_pq_index.py:149: UserWarning: The IVF PQ index is not yet supported, please use with caution.
    warnings.warn("The IVF PQ index is not yet supported, please use with caution.")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================== 1 passed, 1 warning in 1.65s =========================================

And C++ tests pass.

@jparismorgan jparismorgan marked this pull request as ready for review October 17, 2024 20:01
@jparismorgan jparismorgan merged commit b2cd2b6 into main Oct 18, 2024
7 checks passed
@jparismorgan jparismorgan deleted the jparismorgan/ivf-pq-backwards-compat branch October 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants