Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate APIs out of StorageManager: store_array_schema. #5019

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Migrate APIs out of StorageManager: store_array_schema. #5019

merged 4 commits into from
Jun 3, 2024

Conversation

bekadavis9
Copy link
Contributor

@bekadavis9 bekadavis9 commented May 28, 2024 •
edited by KiterLuc
Loading

Migrate APIs out of StorageManager: store_array_schema.

[sc-45794]

TYPE: NO_HISTORY
DESC: Migrate APIs out of StorageManager: store_array_schema.

eric-hughes-tiledb
eric-hughes-tiledb suggested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to track down why you were having linking problems before merging this.

tiledb/api/c_api/dimension_label/CMakeLists.txt Outdated Show resolved Hide resolved
tiledb/api/c_api/dimension_label/dimension_label_api_external.h Outdated Show resolved Hide resolved
@bekadavis9 bekadavis9 marked this pull request as draft May 30, 2024 14:52
@bekadavis9 bekadavis9 force-pushed the rd/sm_migrations-store_array_schema branch from e522159 to 6149fc8 Compare May 30, 2024 19:56
@bekadavis9 bekadavis9 marked this pull request as ready for review May 30, 2024 19:56
eric-hughes-tiledb
eric-hughes-tiledb suggested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few tiny changes; nothing major. Everything else is good.

tiledb/sm/array_schema/array_schema.h Outdated Show resolved Hide resolved
tiledb/sm/array_schema/auxiliary.cc Outdated Show resolved Hide resolved
tiledb/sm/array_schema/auxiliary.h Outdated Show resolved Hide resolved
eric-hughes-tiledb
eric-hughes-tiledb approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bekadavis9 bekadavis9 force-pushed the rd/sm_migrations-store_array_schema branch from 4dacefc to bc1a04b Compare June 2, 2024 20:12
@KiterLuc KiterLuc merged commit da47362 into dev Jun 3, 2024
60 checks passed
@KiterLuc KiterLuc deleted the rd/sm_migrations-store_array_schema branch June 3, 2024 15:04
KiterLuc pushed a commit that referenced this pull request Jun 3, 2024
@bekadavis9 @KiterLuc
Migrate APIs out of StorageManager: store_array_schema. (#5019)
45e5b43 
Migrate APIs out of `StorageManager`: `store_array_schema`.

[sc-45794]

---
TYPE: NO_HISTORY
DESC: Migrate APIs out of `StorageManager`: `store_array_schema`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-hughes-tiledb eric-hughes-tiledb eric-hughes-tiledb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekadavis9 @eric-hughes-tiledb @KiterLuc