Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feedstock and recipe #14

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Conversation

jdblischak
Copy link
Collaborator

While troubleshooting #12, I noticed that the feedstock and recipe would benefit from a refresh.

Feedstock:

  • Fixed Azure links in README. Also required manually renaming the Pipeline in the Azure DevOps UI from the default of "TileDB-Inc.cellxgene-census-feedstock" to "cellxgene-census-feedstock"
  • Added more explicit maintainers
  • Updated conda-forge settings

Recipe:

I wasn't originally planning to bump the build number, but since I did edit the requirements, I did bump it to upload a new binary.

Here's the output from pip check that identified the requirements that needed updating:

+ pip check
cellxgene-census 0.1.dev39+g6ede866.d20241024 has requirement tiledbsoma~=1.11.4, but you have tiledbsoma 1.14.5.
tiledb 0.32.2 has requirement numpy>=1.25; python_version >= "3.9", but you have numpy 1.24.4.

@jdblischak jdblischak self-assigned this Oct 24, 2024
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
Copy link
Collaborator

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you! :)

@jdblischak jdblischak merged commit 9f7c2f6 into TileDB-Inc:main Oct 29, 2024
3 checks passed
@jdblischak jdblischak deleted the update branch October 29, 2024 14:19
@jdblischak
Copy link
Collaborator Author

Quick update on what happened post-merge:

  • Initial job failed due to expired anaconda token
  • @johnkerl rotated token and restarted build, but this still failed due to the expired token. It's a shame that reruns don't use the latest value of the pipeline variables. At least now we have confirmed this is the behavior
  • I manually triggered a new build on main, which successfully uploaded 1.15.0 build number 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants