Add some UI tests

[gjmooney]

#7 Add some UI tests.

[gjmooney]

please update snapshots

[gjmooney]

please update snapshots

[gjmooney]

please update snapshots

[jtpio]

Looks like the snapshot update workflows is failing: https://github.com/TileDB-Inc/jupyter-iframe-commands/actions/runs/12122527111/job/33795905340

We will probably need to first fix the workflow and have the changes available on the main since that workflow runs from main.

Otherwise in the meantime we could grab the snapshots from the playwright report for this PR, and commit them directly.

[gjmooney]

Looks like the snapshot update workflows is failing: https://github.com/TileDB-Inc/jupyter-iframe-commands/actions/runs/12122527111/job/33795905340

We will probably need to first fix the workflow and have the changes available on the main since that workflow runs from main.

Otherwise in the meantime we could grab the snapshots from the playwright report for this PR, and commit them directly.

Yea I'm fighting with this on my fork right now, I didn't want to keep spamming this repo 🫠

[gjmooney]

please update snapshots

[jtpio]

Kicking CI after the snapshot update.

[jtpio]

Looking at the UI tests report, it seems the snapshot is taken a bit too soon before JupyterLab has time to load properly:

jupyter-iframe-commands-ui-tests.webm

Maybe we can introduce an artificial delay, or look for a specific element in the JupyterLab Iframe before taking the snapshot (which would be more robust than relying on an arbitrary timeout).

[gjmooney]

Maybe we can introduce an artificial delay, or look for a specific element in the JupyterLab Iframe before taking the snapshot (which would be more robust than relying on an arbitrary timeout).

I'm attempting to wait for the splash screen to be gone before taking the snapshot

jupyter-iframe-commands/ui-tests/tests/hostpage-tests.spec.ts

Lines 3 to 28 in ab94082

	const waitForApp = async (page: Page) => {
	await page
	.locator('#jupyterlab')
	.contentFrame()
	.locator('#jupyterlab-splash')
	.waitFor({ state: 'detached' });
	await page
	.locator('#jupyterlab')
	.contentFrame()
	.locator('#galaxy')
	.waitFor({ state: 'detached' });
	await page
	.locator('#jupyterlab')
	.contentFrame()
	.locator('#main-logo')
	.waitFor({ state: 'detached' });
	await page
	.locator('#jupyterlab')
	.contentFrame()
	.locator('.jp-LauncherCard-icon')
	.first()
	.waitFor();
	};

but that's not doing it apparently.

[jtpio]

Indeed, and this also looks similar to what Galata does by default: https://github.com/jupyterlab/jupyterlab/blob/a0733bf0ccc29fe8830b89cf557edfa14ffc9fd8/galata/src/fixtures.ts#L352-L355

[gjmooney]

please update snapshots

[jtpio]

Thanks!