Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check-release workflow #24

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix check-release workflow #24

merged 1 commit into from
Dec 9, 2024

Conversation

jtpio
Copy link
Collaborator

@jtpio jtpio commented Dec 5, 2024 •
edited
Loading

Looking into preparing this repo for use with the Jupyter Releaser, so we have automated releases in place and

  • Remove the explicit build from check-release workflow since the real release workflows would not perform that step
  • Make sure both the companion and the extension packages are built on CI

@jtpio
Copy link
Collaborator Author

jtpio commented Dec 6, 2024

The check-release workflow seems to be building the different packages as expected:

image

@jtpio jtpio marked this pull request as ready for review December 9, 2024 09:57
@jtpio jtpio changed the title Prepare for the Jupyter Releaser Fix check-release workflow Dec 9, 2024
@jtpio
Copy link
Collaborator Author

jtpio commented Dec 9, 2024

Looks like the jupyter-iframe-commands-host does not get its version bumped correctly. Will address that in a separate PR.

@jtpio jtpio merged commit 9a0fc63 into main Dec 9, 2024
11 checks passed
@jtpio jtpio deleted the fix-releaser-setup branch December 9, 2024 12:14
@jtpio jtpio mentioned this pull request Dec 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtpio