Improve demo styling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot please update snapshots |
|
bot please update snapshots |
gjmooney
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
I just have some small suggestions. The scrollbar overlaps the iframe on Firefox, (and I thought it looked a little awkward with the iframe all the way against the edge) , so it could be nice to a little room on the sides.
Here's what the scrollbar looks like in Firefox:
Co-authored-by: Greg Mooney <gregory.mooney@quantstack.net>
|
bot please update snapshots |
|
Thanks @gjmooney for taking a look! Looks like it should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some styling tweaks for the demo:
jupyter-iframe-commands-demo-tweaks.webm