Fix evp 1d masking issues #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There are relatively rare cases/gridcells where stress (tmask) and stepu (umask) are advanced without the other. The 1d evp implementation was not addressing this issue, so skiptcell was added to the 1d evp (similar to skipucell) to mask out cells separately for stress and stepu. This fixed a few non bit-for-bit cases in testing. - Cleaned up some indentation and other minor issues in 1d evp. - Updated the evp_algorithm log output in ice_init.
12 tasks
|
Looks good to me. Will test in our end as well, but merging as is. |
TillRasmussen
added a commit
that referenced
this pull request
Nov 19, 2021
#17) * Changes in ice_dyn* are interpolation of uvelE/vvelN to B grid. ice_transport files are changed in a way so that velocities are interpolated to b grid for depature point function and kept at E or N grid possible. * changed according to comments. changed average from F to S and. commented out in vp and eap * comment out grid_system, uvelE and vvelN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Fix evp 1d masking issues, seems to be final fix to get 1d debug results bit-for-bit with 2d.
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Full test suites run on cheyenne with intel, pgi, and gnu. Tested 1d evp debug vs 2d evp debug. Also tested standard test suite vs baseline. All results are as expected. alt04 results are different, 1x1 and 2x2 still broken, unit tests different, some tests time out in debug mode due to slower run times. There were partly run manually, but mostly just skipped. We have a large sample of positive results, so we shoudl be OK. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#126245535038576bb68746004754915fe96ee06c
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
There are relatively rare cases/gridcells where stress (tmask) and stepu (umask) are advanced
without the other. The 1d evp implementation was not addressing this issue, so skiptcell was added
to the 1d evp (similar to skipucell) to mask out cells separately for stress and stepu. This
fixed a few non bit-for-bit cases in testing.
Cleaned up some indentation and other minor issues in 1d evp.
Updated the evp_algorithm log output in ice_init.