does this work #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add cice.make script, list makdep as prerequisite
* cice.make can be used to easily call make with the different targets
present in the Makefile (db_files, db_flags, clean), or to pass
different flags to make
* makdep is listed as a prerequisite of the *.d files, such that
we don't need to call make makdep separately in cice.build
* Update db_files and db_flags rules in Makefile
* Remove $(INCS) variable from build rules
The -I flag is used by Fortran compilers to locate files
included via the "#include" preprocessor directive or the "include" statement,
or modules referenced via the "use" statement. In our codebase we only use
modules, and all modules files (*.mod) are put in the ${ICE_OBJDIR} directory,
where the compilation takes place. So there is no need for all source directories
(contained in the variable $(INCS), prefixed with -I) to be added to the build
rules. This shortens the length of the displayed compilation lines.
* Update documentation
* add cice.build argument capabilities
* update documentation
* update documentation
* update documentation
* cleanup of documentation and implementation
* update implementation based on reviews
* update documentation
* update documentation
* update documentation
* update documentation
* update Makefile and documentation
* izumi initial port * update izumi port and add nothread_suite * update kind conversions in ice_dyn_evp_1d.F90
* Fix local solar time * Add line for going past 24 * New LST calculation Addresses #3.
…nsortium#358) * Refactor boxslotcyl initialization to use icepack parameters * Fix documentation typo * Correct use statement rename syntax * Change days_to_s to secday
* fixing rst errors * removing implementation notes line
* update icepack, nag cleanup, remove tabs * update dyrect in boxslotcyl
* adding COREII citation * modifying PR template for RTD change
CICE-Consortium#350) * Added new capability in ice_forcing.F90 to test with JRA55 atmospheric forcing on gx1 grid. * Added JRA55 as an option under atm_data_type * Modified ice_forcing.F90 by replacing elseif (trim(atm_data_format) == 'nc') then ! netcdf with elseif (trim(atm_data_type) == 'JRA55') then ! netcdf Corrected comment regarding JRA55 forcing to state "E.g. record 1 gives conditions at 3 am GMT on 1 January" Modified ./scripts/options/set_nml.jra55 by setting use_restart_time = .false. setting year_init = 2005 setting fyear_init - 2005 and corrected units for precip_units = 'mks' edited ./scripts/tests/base_suite.ts by reinstating bgc restart test and added a jra55 "short" smoke test. * fix an incorrect test in the base suite * Add a check in init_forcing_atmo to check if 'use_leap_years' is set to true. If so, abort if the atm_data_type is not JRA55, default, or box2001 * Fix a mistake in diagnostic warning output for the use_leap_years check * set use_leap_years to false in the boxrestore namelist option file * add use_restart_time specification to test_nml.restart* files * Remove options in JRA55 namelist option file that are the same as the default in ice_in. Also remove the specification of use_restart_time to .false. * fix a bug in the newly-implemented use_leap_years check during initialization * add use_leap_years and use_restart_time specification to jra55 namelist option file * add new jra55_2008 and run90day namelist option files * modify the JRA55 smoke test to be a 90 day test and start in 2008. Also add a restart test for JRA55 in base_suite * update documentation to include citation for JRA55
…e_dyn_evp_1d (CICE-Consortium#367) * merge ice_dyn_evp_1d modules and update ice_dyn_evp_1d interface names. Add get_bathymetry_popfile from RASM * remove old code * remove old code
…m#370) * update zenodo json template and report_results script * update .gitignore add testsuite* * update zenodo json file * update gitignore again and add ciceexe cleanup
* NUOPC branch * initial CICE6 port to CESM+NUOPC * clean up nu_diag initialization due to complexity added by nuopc cap * add nu_diag_set flag to work around the nu_diag setting in the nuopc cap * update cice driver directories * update documentation * update documentation * update documentation * update documentation * fix minor bug in cice.setup that affects settings parsing without final carriage return * update documentation * rename drivers/subroutine to drivers/direct and update documentation
Update from upstream
TillRasmussen
pushed a commit
that referenced
this pull request
Nov 17, 2021
Add a subroutine mimicking what 'viscous_coeffs_and_rep_pressure' does, but at a single location. Name it '*_T' since it's going to be used to compute the viscous coefficients and replacement pressure at the T point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
ENTER INFORMATION HERE
ENTER INFORMATION HERE
ENTER INFORMATION HERE