Skip to content
This repository has been archived by the owner on Apr 2, 2022. It is now read-only.

Add some more XFAttributes and extension methods #19

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Add some more XFAttributes and extension methods #19

merged 5 commits into from
Dec 7, 2021

Conversation

edgarfgp
Copy link
Contributor

While Im still trying to figure out the changes needed for #12 . and in order to make so small progress helping , I'm raising this PR to add some more useful extensions and properties

Copy link
Collaborator

@twop twop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Copy link
Owner

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
I've added some comments

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Dec 1, 2021

@TimLariviere This is ready for another review :)

Copy link
Owner

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's merge this one :)

@TimLariviere TimLariviere merged commit 5aa1ff0 into TimLariviere:main Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants