Fix the NaN bug reported in issue 21 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the bug reported in TimMikeladze#21
… errors The only number to report as a singular is when there is one item. Zero should be reported as a plural. Was: `0 error already in baseline.` Now: `0 errors already in baseline.`
wdoug
reviewed
Jun 5, 2024
wdoug
reviewed
Jun 5, 2024
- Use strict equality - Specify that these are new errors Co-authored-by: Will Douglas <willygdouglas@gmail.com>
Co-authored-by: Will Douglas <willygdouglas@gmail.com>
|
Thanks for the helpful suggestions @wdoug ! |
|
@TimMikeladze, any chance we could move to get this merged/get this bug fixed soon? |
|
I’ll merge all the PRs in the next 24hrs or so. I’m flying internationally
so have been a bit busy to sit down and review.
I appreciate the contributions!
Tim Mikeladze
…On Fri, Jun 7, 2024 at 23:24 Will Douglas ***@***.***> wrote:
@TimMikeladze <https://github.com/TimMikeladze>, any chance we could move
to get this merged/get this bug fixed soon?
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFLR7UTISTEEBVS2G2RAOTZGIQHRAVCNFSM6AAAAABI3NFAG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGU3TSMBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Published as |
|
I didn't mean to rush you while you were traveling! Anyway, thanks for getting this merged and published, @TimMikeladze! |
|
I hope your travels went smoothly. Thanks for the review and merge @TimMikeladze ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21 .
I really don't know why the compiler wanted to convert the TypeScript code the wrong way, but using
Array.frominstead of the spread operator and the array initializer seemed to work properly in my tests.While I was at it, I fixed up the pluralization logic, but if that's getting off topic, I can yank that commit.
What do you think?