FIX support SSH CA user signed keys in ssh_agent #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR mscdex#808 publickey support for SSH certificates is great but I found it was failing with when the keys and signed certificates where in ssh_agent
The changes I propose in this PR enable signed certs
ssh-rsa-cert-v01@openssh.com
to be correctly handled by the SSH client when retrieved from SSH_AGENT. This is the default certificate type returned by Hashicorp Vault SSH CA signing.This PR does not handle the multitude of possible cert types and robustly handle the errors if this where the case. I don't like submitting something not fully complete but I am a Newbie to this wonderful world of PublicKey and Security so would hope someone with suitable experience would more confidently and robustly fill in the general cases. Thansk to @TimWolla for original work implementing Publickey Certificate support and hope @mscdex will review and merge soon