This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
feat: Add strptime and strftime to datetime classes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- strftime and strptime easily map to DateTimeFormatterBuilder, although with a different syntax. - strftime and strptime are implementation dependent, yielding different results on different operating systems and locale definitions. - The JVM locale is set to the Python's locale on startup
triceo
approved these changes
Jul 1, 2024
|
Good to merge when green. |
|
Fixes #103 |
Need to disable the full text weekday and month tests, since Java's C Locale defines the full text weekday and month for the C locale as the short text weekday and month.
|
|
Coverage cannot really be improved due to JVM C's locale differences with Python's C's locale (which are commented in the tests). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strftime and strptime easily map to DateTimeFormatterBuilder, although with a different syntax.
strftime and strptime are implementation dependent, yielding different results on different operating systems and locale definitions.
The JVM locale is set to the Python's locale on startup