fix: allow @PlanningId to be defined on interfaces #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `getAllMembers` excluded members defined in interfaces. Presumably, this was because methods would have implementations in the implementing class. However, there is a flaw in that logic: implementations of a method do not inherit the annotations of the declared method. As a result, when LookupManager looks up the accessor of a class whose @PlanningId is defined in an interface, it finds none. `getAllMembers` is changed to add all interface methods to the member list, thus allowing interface members to be used in lookups.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
previously approved these changes
Aug 29, 2024
core/src/main/java/ai/timefold/solver/core/config/util/ConfigUtils.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/config/util/ConfigUtils.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/config/util/ConfigUtils.java
Outdated
Show resolved
Hide resolved
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
triceo
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
getAllMembersexcluded members defined in interfaces. Presumably, this was because methods would have implementations in the implementing class.However, there is a flaw in that logic: implementations of a method do not inherit the annotations of the declared method. As a result, when LookupManager looks up the accessor of a class whose @PlanningId is defined in an interface,
it finds none.
getAllMembersis changed to add all interface methods to the member list, thus allowing interface members to be used in lookups.