Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple SolverManager instances (Spring-boot) #590

Merged
merged 10 commits into from
Jan 26, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jan 24, 2024

This pull request updates the Spring boot extension to support multiple instances of Solver in an application. The new logic utilizes a map to keep track of the configurations, and nothing changes for the current behavior for single solvers, which are mapped by default to the key name default.

@zepfred zepfred linked an issue Jan 24, 2024 that may be closed by this pull request
@zepfred zepfred requested a review from triceo January 24, 2024 18:18
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Leaving some comments.

@zepfred zepfred requested a review from triceo January 25, 2024 19:21
@triceo triceo merged commit 9009fa4 into TimefoldAI:main Jan 26, 2024
9 of 10 checks passed
@zepfred zepfred deleted the multiple-solvers-spring#351 branch March 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 2 SolverManager instances in Quarkus with @Named
2 participants