Merge pull request #141 from TimeleapLabs/feature-bls-test

✨ feat(bls-test): add unittest for bls and move bls sign to identity …
TimeleapLabs · Jun 22, 2024 · 91d0177 · 91d0177
2 parents 026801e + fadecbf
commit 91d0177
Show file tree

Hide file tree

Showing 6 changed files with 63 additions and 18 deletions.
diff --git a/internal/crypto/bls/bls.go b/internal/crypto/bls/bls.go
@@ -1,8 +1,6 @@
 package bls
 
 import (
-	"math/big"
-
 	bls12381 "github.com/consensys/gnark-crypto/ecc/bls12-381"
 )
 
@@ -11,16 +9,6 @@ func Hash(message []byte) (bls12381.G1Affine, error) {
 	return bls12381.HashToG1(message, dst)
 }
 
-func Sign(secretKey big.Int, message []byte) (bls12381.G1Affine, bls12381.G1Affine) {
-	hashedMessage, err := Hash(message)
-	if err != nil {
-		panic(err)
-	}
-	signature := new(bls12381.G1Affine).ScalarMultiplication(&hashedMessage, &secretKey)
-
-	return *signature, hashedMessage
-}
-
 func RecoverSignature(bytes [48]byte) (bls12381.G1Affine, error) {
 	signature := new(bls12381.G1Affine)
 	_, err := signature.SetBytes(bytes[:])

diff --git a/internal/crypto/bls/identity.go b/internal/crypto/bls/identity.go
@@ -73,6 +73,17 @@ func NewIdentity() *Signer {
 	return s
 }
 
+// Sign signs a message with the identities secret key.
+func (s *Signer) Sign(message []byte) (bls12381.G1Affine, bls12381.G1Affine) {
+	hashedMessage, err := Hash(message)
+	if err != nil {
+		panic(err)
+	}
+	signature := new(bls12381.G1Affine).ScalarMultiplication(&hashedMessage, s.SecretKey)
+
+	return *signature, hashedMessage
+}
+
 // Verify verifies the signature of a message belongs to the public key.
 func (s *Signer) Verify(
 	signature bls12381.G1Affine, hashedMessage bls12381.G1Affine, publicKey bls12381.G2Affine,

diff --git a/internal/crypto/bls/identity_test.go b/internal/crypto/bls/identity_test.go
@@ -0,0 +1,48 @@
+package bls
+
+import (
+	"testing"
+
+	"github.com/TimeleapLabs/unchained/internal/config"
+	"github.com/stretchr/testify/suite"
+)
+
+const SamplePrivateKey = "3b885a8a8f043724abfa865eccd38f536887d9ea1c08a742720e810f38a86872"
+
+var (
+	TestMessage   = []byte("test message")
+	SecondMessage = []byte("second message")
+)
+
+type TestIdentitySuit struct {
+	suite.Suite
+	signer *Signer
+}
+
+func (s *TestIdentitySuit) SetupTest() {
+	config.App.System.AllowGenerateSecrets = true
+	config.App.Secret.EvmPrivateKey = SamplePrivateKey
+
+	s.signer = NewIdentity()
+}
+
+func (s *TestIdentitySuit) TestVerifyIdentity() {
+	signature, messageHash := s.signer.Sign(TestMessage)
+	isValid, err := s.signer.Verify(signature, messageHash, *s.signer.PublicKey)
+	s.NoError(err)
+	s.True(isValid)
+
+	secondSignature, secondMessageHash := s.signer.Sign(SecondMessage)
+
+	isValid, err = s.signer.Verify(signature, secondMessageHash, *s.signer.PublicKey)
+	s.NoError(err)
+	s.False(isValid)
+
+	isValid, err = s.signer.Verify(secondSignature, messageHash, *s.signer.PublicKey)
+	s.NoError(err)
+	s.False(isValid)
+}
+
+func TestIdentitySuite(t *testing.T) {
+	suite.Run(t, new(TestIdentitySuit))
+}
diff --git a/internal/service/evmlog/process.go b/internal/service/evmlog/process.go
@@ -14,7 +14,6 @@ import (
 
 	"github.com/TimeleapLabs/unchained/internal/config"
 	"github.com/TimeleapLabs/unchained/internal/crypto"
-	"github.com/TimeleapLabs/unchained/internal/crypto/bls"
 	"github.com/dgraph-io/badger/v4"
 	goEthereum "github.com/ethereum/go-ethereum"
 	"github.com/ethereum/go-ethereum/accounts/abi"
@@ -164,7 +163,7 @@ func (s *service) ProcessBlocks(ctx context.Context, chain string) error {
 			}
 
 			toHash := event.Sia().Bytes()
-			signature, hash := bls.Sign(*crypto.Identity.Bls.SecretKey, toHash)
+			signature, hash := crypto.Identity.Bls.Sign(toHash)
 
 			if conf.Send {
 				s.SendPriceReport(signature, event)

diff --git a/internal/service/uniswap/uniswap.go b/internal/service/uniswap/uniswap.go
@@ -355,7 +355,7 @@ func (s *service) syncBlock(ctx context.Context, token model.Token, caser cases.
 		},
 	}
 
-	signature, hash := bls.Sign(*crypto.Identity.Bls.SecretKey, priceInfo.Sia().Bytes())
+	signature, hash := crypto.Identity.Bls.Sign(priceInfo.Sia().Bytes())
 
 	if token.Send && !conn.IsClosed {
 		compressedSignature := signature.Bytes()

diff --git a/internal/transport/client/handler/challenge.go b/internal/transport/client/handler/challenge.go
@@ -2,14 +2,13 @@ package handler
 
 import (
 	"github.com/TimeleapLabs/unchained/internal/crypto"
-	"github.com/TimeleapLabs/unchained/internal/crypto/bls"
 	"github.com/TimeleapLabs/unchained/internal/model"
 )
 
 func (h *consumer) Challenge(message []byte) []byte {
 	challenge := new(model.ChallengePacket).FromBytes(message)
 
-	signature, _ := bls.Sign(*crypto.Identity.Bls.SecretKey, challenge.Random[:])
+	signature, _ := crypto.Identity.Bls.Sign(challenge.Random[:])
 	challenge.Signature = signature.Bytes()
 
 	return challenge.Sia().Bytes()
@@ -18,7 +17,7 @@ func (h *consumer) Challenge(message []byte) []byte {
 func (w worker) Challenge(message []byte) []byte {
 	challenge := new(model.ChallengePacket).FromBytes(message)
 
-	signature, _ := bls.Sign(*crypto.Identity.Bls.SecretKey, challenge.Random[:])
+	signature, _ := crypto.Identity.Bls.Sign(challenge.Random[:])
 	challenge.Signature = signature.Bytes()
 
 	return challenge.Sia().Bytes()