url: fix handling of ? in URLSearchParams creation

Fixes: nodejs#11093
TimothyGu · Feb 14, 2017 · 2b95bf3 · 2b95bf3
1 parent 781eb90
commit 2b95bf3
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -97,12 +97,11 @@ function onParseComplete(flags, protocol, username, password,
   ctx.query = query;
   ctx.fragment = fragment;
   ctx.host = host;
-  if (this[searchParams]) {  // invoked from href setter
-    initSearchParams(this[searchParams], query);
-  } else {
-    this[searchParams] = new URLSearchParams(query);
+  if (!this[searchParams]) { // invoked from URL constructor
+    this[searchParams] = new URLSearchParams();
+    this[searchParams][context] = this;
   }
-  this[searchParams][context] = this;
+  initSearchParams(this[searchParams], query);
 }
 
 // Reused by URL constructor and URL#href setter.