-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report:Error parsing JSON. JSON was null. #20
Comments
That didn't take long. I'll dig into it. |
@CMTriX, Were there any error messages prior to the "JSON was null" message? |
Also, what happens if you go to |
I published 0.9.1 which has additional logging to help diagnose the null JSON error. If you have a chance, install that release and when the issue reoccurs attach the log. Mask or omit any details you feel necessary. Thanks, |
status "fail" |
When error pops up again, i will send the log. Thank you! |
This indicates a problem connecting to ip-api.com. I don't have a clue where "members" in the URL comes from. This behavior could certainly be causing the Json to be null. I'm super busy with real life obligations today. I may not be able to look any further until tomorrow. Tim |
SSL unavailable for this endpoint, order a key at https://members.ip-api.com/ |
Here's the problem I'm facing, there are several providers that will supply public IP information for free. However, most of them want the user to sign up for a key. Of the few that don't require a key, ip-api.com offered the most details. Now it appears that somehow you are being redirected to the URL that requires a key. I won't ask users of GetMyIP to get a key to be able to use the app. That would simply be a nonstarter for many. I want GetMyIP to work, without errors, for everyone that wants to use it. The way I see it I have 3 choices.
What would you do if you were in my shoes? Tim |
maybey just wait until more reports are coming. After my JSON error, i refreshed and then it worked. |
@CMTriX, thanks for your ideas. Your last comment started me thinking... In the log file, there is a line like "Discovering external IP information took ###.## ms". Would you collect a few of those lines, for both when the app fails and when it works. Label each with fail or success, then paste them into the issue. Thanks, |
@CMTriX Disregard my last message. I think I have the problem isolated and corrected. Long day, I'll pick this up again tomorrow. Tim |
Started program many times now, but the error is not showing ... grr... ;) Anything else: |
2023/10/27 09:40:09.70 INFO GetMyIP (Get My IP) 0.9.1.0 is starting up |
I believe that the error that happened in this case was the parsing of the Json that's supposed to contain the external IP information started before it should have. I changed how this works and hopefully it doesn't happen again. If it does, please let me know. Tim |
Is there an existing issue for this?
What happened or didn't happen?
Error parsing JSON. JSON was null.
System.ArgumentNullException: Value cannot be null. (Parameter 'json')
at System.Text.Json.JsonSerializer.Deserialize[TValue](String json, JsonSerializerOptions options)
at GetMyIP.Helpers.IpHelpers.<>c__DisplayClass5_0.b__0()
Steps To Reproduce
after installation with checkbox run after install checked
Version
0.9.0
Windows Version
(all updates) Microsoft Windows 10.0.22621
Relevant log output
Anything else?
No response
The text was updated successfully, but these errors were encountered: