-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Italian language #25
Conversation
Add also Dutch language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bovirus Thank you so much for the translation. Thanks also for including the Dutch translation from @CMTriX in the PR.
I'm going to approve and merge tonight. However, there are a couple of issues.
- I left out a couple of the
xml:space
tags. I will fix these in each language file after the merge. - While working on the project the last few days I've added about 5 strings and updated 2 more.
Tim
@bovirus and @CMTriX I have both the Italian and Dutch files working in the app. There are UI tweaks needed, such as buttons and other controls to narrow to accommodate the longer text, a weird alignment problem, and for some reason the tooltip for the tray icon is 0 bytes in Italian and Dutch. It's been a long day, my eyes are tired, so I'll pick this up in the morning. I did get the missing tags added to the language files and pushed back to GitHub. Also, I keep forgetting to ask, on the External IP page, is there a word for State that would be more appropriate for your locality? Thanks, |
No problem. |
Please add new strings and I will update it too. |
-State- / Provincie In the Netherlands we don't have states. |
These 2 strings were updated: <sys:String x:Key="MsgText_Error_JsonNull" xml:space="preserve">JSON file is null. Please consider opening an issue and attaching the log file.</sys:String>
<sys:String x:Key="MsgText_Error_JsonParsing" xml:space="preserve">Error parsing JSON. {0} Please consider opening an issue and attaching the log file.</sys:String> These are new: <sys:String x:Key="SettingsItem_PublicInfoProvider">External IP information provider</sys:String>
<sys:String x:Key="SettingsItem_PublicInfoProviderTooltip" xml:space="preserve">ip-api.com provides full details ipext.org provides IP address only</sys:String>
<sys:String x:Key="SettingsEnum_Provider_IpApiCom">ip-api.com</sys:String>
<sys:String x:Key="SettingsEnum_Provider_IpExtOrg">ipext.org</sys:String>
<sys:String x:Key="SettingsItem_ObfuscateLog">Obfuscate IP details in log file</sys:String>
<sys:String x:Key="About_Contribute">Contribute</sys:String>
<sys:String x:Key="About_ContributeToolTip">How to contribute a translation</sys:String> |
<sys:String x:Key="SettingsItem_PublicInfoProvider">Externe IP informatie provider</sys:String> <sys:String x:Key="SettingsEnum_Provider_IpApiCom">ip-api.com</sys:String> <sys:String x:Key="SettingsItem_ObfuscateLog">Verberg IP details in het logbestand</sys:String> <sys:String x:Key="About_Contribute">Bijdrage</sys:String> |
Hallo Tim..., I created a new translation of Slovak lang. (sk-SK) how to add it ??? |
Make a clone of the repository. Then create a PR with your language. Or post here your file. And I can do it. Please translate these strings for instalelr. ViewReadme=View the ReadMe file |
I send file... |
Please translate the strings (text after "=") in your language. ViewReadme=View the ReadMe file Is it OK ViewReadme=Zobraziť súbor ReadMe |
Hallo, where I download necessary file (full version) strings for translate?, I use portable(no install) version... |
Please conftrm the strings for installer. The file that you sent is not for getMyip and not for Windows update Viewer The GetMyip language files are here. https://github.com/Timthreetwelve/GetMyIP/tree/main/GetMyIP/Languages please check and update your Slovak language using as base for compare master English language https://github.com/Timthreetwelve/GetMyIP/blob/main/GetMyIP/Languages/Strings.en-US.xaml if you are agree i think to close this ticket and open a new with a title like "Ccontribute about translation" I propose to add in the header (comment) of language file the info about program that translatiion if for. |
I'm just starting my day here and I see that you've been busy. 😃 Yes, please create a new issue for this. We shouldn't be adding to issues/PRs that have been closed/merged anyway, it makes it difficult for me find the new comments. I like the idea of the application name being inside the comment block at the top of the language files. 👍🏻 I pushed an update to Strings.en-US. I'll be back later today. |
@Timthreetwelve
Please check and merge, Thanks.