Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian language #25

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add Italian language #25

merged 2 commits into from
Oct 27, 2023

Conversation

bovirus
Copy link
Collaborator

@bovirus bovirus commented Oct 26, 2023

@Timthreetwelve

Please check and merge, Thanks.

@bovirus
Copy link
Collaborator Author

bovirus commented Oct 26, 2023

Add also Dutch language

Copy link
Owner

@Timthreetwelve Timthreetwelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bovirus Thank you so much for the translation. Thanks also for including the Dutch translation from @CMTriX in the PR.

I'm going to approve and merge tonight. However, there are a couple of issues.

  1. I left out a couple of the xml:space tags. I will fix these in each language file after the merge.
  2. While working on the project the last few days I've added about 5 strings and updated 2 more.

Tim

@Timthreetwelve Timthreetwelve merged commit 5598828 into Timthreetwelve:main Oct 27, 2023
@Timthreetwelve
Copy link
Owner

@bovirus and @CMTriX I have both the Italian and Dutch files working in the app. There are UI tweaks needed, such as buttons and other controls to narrow to accommodate the longer text, a weird alignment problem, and for some reason the tooltip for the tray icon is 0 bytes in Italian and Dutch. It's been a long day, my eyes are tired, so I'll pick this up in the morning.

I did get the missing tags added to the language files and pushed back to GitHub. Also, I keep forgetting to ask, on the External IP page, is there a word for State that would be more appropriate for your locality?

Thanks,
Tim

@bovirus
Copy link
Collaborator Author

bovirus commented Oct 27, 2023

@Timthreetwelve

No problem.
Please ad dnew strings and I will update it.
I'm working on Inno Setup Installer script.

@CMTriX
Copy link
Collaborator

CMTriX commented Oct 27, 2023

Please add new strings and I will update it too.

@CMTriX
Copy link
Collaborator

CMTriX commented Oct 27, 2023

-State- / Provincie

In the Netherlands we don't have states.

@Timthreetwelve
Copy link
Owner

@CMTriX

These 2 strings were updated:

<sys:String x:Key="MsgText_Error_JsonNull" xml:space="preserve">JSON file is null.&#13;Please consider opening an issue and attaching the log file.</sys:String>
<sys:String x:Key="MsgText_Error_JsonParsing" xml:space="preserve">Error parsing JSON.&#13;{0}&#13;Please consider opening an issue and attaching the log file.</sys:String>

These are new:

<sys:String x:Key="SettingsItem_PublicInfoProvider">External IP information provider</sys:String>
<sys:String x:Key="SettingsItem_PublicInfoProviderTooltip" xml:space="preserve">ip-api.com provides full details&#13;ipext.org provides IP address only</sys:String>

<sys:String x:Key="SettingsEnum_Provider_IpApiCom">ip-api.com</sys:String>
<sys:String x:Key="SettingsEnum_Provider_IpExtOrg">ipext.org</sys:String>

<sys:String x:Key="SettingsItem_ObfuscateLog">Obfuscate IP details in log file</sys:String>

<sys:String x:Key="About_Contribute">Contribute</sys:String>
<sys:String x:Key="About_ContributeToolTip">How to contribute a translation</sys:String>

@CMTriX
Copy link
Collaborator

CMTriX commented Oct 28, 2023

<sys:String x:Key="SettingsItem_PublicInfoProvider">Externe IP informatie provider</sys:String>
<sys:String x:Key="SettingsItem_PublicInfoProviderTooltip" xml:space="preserve">ip-api.com levert uitgebreide details ipext.org levert alleen het IP adres</sys:String>

<sys:String x:Key="SettingsEnum_Provider_IpApiCom">ip-api.com</sys:String>
<sys:String x:Key="SettingsEnum_Provider_IpExtOrg">ipext.org</sys:String>

<sys:String x:Key="SettingsItem_ObfuscateLog">Verberg IP details in het logbestand</sys:String>

<sys:String x:Key="About_Contribute">Bijdrage</sys:String>
<sys:String x:Key="About_ContributeToolTip">Hoe kan ik een vertaling bijdragen?</sys:String>

@Vaso73
Copy link

Vaso73 commented Oct 30, 2023

@Timthreetwelve

Hallo Tim..., I created a new translation of Slovak lang. (sk-SK) how to add it ???

@bovirus
Copy link
Collaborator Author

bovirus commented Oct 30, 2023

@Vaso73

Make a clone of the repository. Then create a PR with your language.

Or post here your file. And I can do it.

Please translate these strings for instalelr.

ViewReadme=View the ReadMe file
AppIsRunning=is running, please close it to continue with the installation.
DeleteConfigFiles=Do you want to remove the settings files?%n%nSelect 'No' if you plan on reinstalling.

@Vaso73
Copy link

Vaso73 commented Oct 30, 2023

I send file...
Strings.sk-SK.zip

@bovirus
Copy link
Collaborator Author

bovirus commented Oct 30, 2023

@Vaso73

Please translate the strings (text after "=") in your language.

ViewReadme=View the ReadMe file
AppIsRunning=is running, please close it to continue with the installation.
DeleteConfigFiles=Do you want to remove the settings files?%n%nSelect 'No' if you plan on reinstalling.

Is it OK

ViewReadme=Zobraziť súbor ReadMe
AppIsRunning=beží, zatvorte ho, aby ste mohli pokračovať v inštalácii.
DeleteConfigFiles=Chcete odstrániť súbory nastavení?%n%nAk plánujete preinštalovať, vyberte 'Nie'.

@Vaso73
Copy link

Vaso73 commented Nov 2, 2023

Hallo, where I download necessary file (full version) strings for translate?, I use portable(no install) version...

@bovirus
Copy link
Collaborator Author

bovirus commented Nov 2, 2023

@Vaso73

Please conftrm the strings for installer.

The file that you sent is not for getMyip and not for Windows update Viewer

The GetMyip language files are here.

https://github.com/Timthreetwelve/GetMyIP/tree/main/GetMyIP/Languages

please check and update your Slovak language using as base for compare master English language

https://github.com/Timthreetwelve/GetMyIP/blob/main/GetMyIP/Languages/Strings.en-US.xaml

@Timthreetwelve

if you are agree i think to close this ticket and open a new with a title like

"Ccontribute about translation"

I propose to add in the header (comment) of language file the info about program that translatiion if for.

@Timthreetwelve
Copy link
Owner

@bovirus

I'm just starting my day here and I see that you've been busy. 😃

Yes, please create a new issue for this. We shouldn't be adding to issues/PRs that have been closed/merged anyway, it makes it difficult for me find the new comments.

I like the idea of the application name being inside the comment block at the top of the language files. 👍🏻 I pushed an update to Strings.en-US.

I'll be back later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants