-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: experimental_hash_all_targets #47
Comments
Hello @jonahgeorge, I was actually able to make your example work with the provided example script in the repo I have made a fork of your repo above to show how to get this working:
The issue is that for |
Ah, I think I tracked it down... looking at your script I see that
I was under the assumption that This makes sense and seems significantly faster when you have access to which files have changed, but poses some problems when operating in an environment in which you can't feasibly execute Would you consider a patch to |
@jonahgeorge I like the idea of allowing users to scan all input files via a flag, what flag name makes sense to you? |
I'd lean towards something like Potentially related: |
@jonahgeorge can you try out #52 locally and see if that works for you? |
@jonahgeorge Did this end up working for you? |
Unfortunately trying it out of the box with my company's primary monorepo yielded bad results: After 20 minutes the generate-hashes command was still running. I'll try to carve out some time to try on a smaller repo and also investigate whether the hash generation could be parallelized. |
Thank you @jonahgeorge, Ill admit this is now how we use the tool, we use the |
Hey @tinder-maxwellelliott, I encountered an interesting issue which appears to be coming from the hash function. I've put together a small repro below showing that the hashes from
generate-hashes
are not changing even when the source files are changing. Have you seen this before? Based on my understanding of therule_implementation_hash
bug, I don't think this is related but my exposure to this is pretty limited right now.https://github.com/jonahgeorge/bazel-diff-repro
The text was updated successfully, but these errors were encountered: