Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to use 2.1.4 for "Integrate into your project" #57

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

Panfilwk
Copy link
Contributor

Was upgrading to the latest version to see if #47 would solve an issue I was having, and noticed that target definition in the README still pointed to 2.1.2.

I wonder if it would be better to include the target definition with github releases for each version, rather than keeping only latest in the README?

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2021

CLA assistant check
All committers have signed the CLA.

@Panfilwk
Copy link
Contributor Author

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Working with my employer to figure out whether to sign this CLA personally, or whether our org should broadly accept the CLA if we plan to continue using this tool going forward. Hopefully I can get it signed in one of those two ways either tomorrow or early next week :)

@tinder-maxwellelliott
Copy link
Collaborator

@Panfilwk Ready to merge this once the CLA is in!

@Panfilwk
Copy link
Contributor Author

CLA should be in, ended up just signing personally; sorry it took me a while to get in touch with legal dept for my employer.

@tinder-maxwellelliott tinder-maxwellelliott merged commit b0dc538 into Tinder:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants