feat: upgrade to angular 13 #18
Conversation
…d-state-algorithm fix: improved asymptotic of extend func from O(n^2) to o(n)
|
I tested by running |
|
@MarsiBarsi are you planning to review and merge this? |
|
Let me know if there is anything further I should do. I don't mind helping to ensure this package always works for the latest angular version (though I would not have time to add features). I could also fork the repo/npm package if that's easier. |
|
Would be awesome if this Pull Request lands, as we have to always use |
|
🎉 This issue is included in version core@5.0.0 🎉 The release is available on GitHub release |
|
🎉 This issue is included in version browser@5.0.0 🎉 The release is available on GitHub release |
|
🎉 This issue is included in version angular@5.0.0 🎉 The release is available on GitHub release |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Published
@micro-sentry/angularbuilds use legacy View Engine, Angular 13 now publishes only Ivy.Closes #17
What is the new behavior?
By upgrading to Angular 13, published package will now ship only with Ivy.
Does this PR introduce a breaking change?
Any Angular project that doesn't have Ivy enabled may break. Ivy was made default in Feb Angular 9 in 2020, over two years ago. Projects running Angular <9 should upgrade their Angular version before upgrading micro-sentry.
@micro-sentry/coreshould be unaffected.Other information
Tests pass, I'm marking draft as I continue testing it. I'm not very familiar with nx, so it would be good to build the package and ensure it works as expected.
It's worth pointing out that micro-sentry doesn't even have html templates. This change isn't going to do a whole lot. Still, keeping up to date packages is a good practice and it will slightly speed up builds and remove a warning when installing the package.
I had to add this nx bug workaround for jest to work. Everything else is from the automated nx upgrade process.