-
Notifications
You must be signed in to change notification settings - Fork 9
add conservative reconnection strategy; #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-vovk
suggested changes
Feb 15, 2022
i-vovk
suggested changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, rebase on latest develop, there was a mistake and .ipp files weren't linted or format-checked by CI
i-vovk
force-pushed
the
add-reconnection-strategy
branch
from
February 16, 2022 08:14
854390a
to
8a21398
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
old reconnection strytegy is used by default as default parametr, should not break build to anyone;
i-vovk
force-pushed
the
add-reconnection-strategy
branch
from
February 16, 2022 08:44
8a21398
to
affed82
Compare
i-vovk
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old reconnection strategy is used by default as the default parameter, should not break the build to anyone;