Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议重构对本体gain事件的覆盖 #9

Closed
universe-st opened this issue Oct 6, 2023 · 1 comment
Closed

建议重构对本体gain事件的覆盖 #9

universe-st opened this issue Oct 6, 2023 · 1 comment

Comments

@universe-st
Copy link
Collaborator

《十周年UI》中对本体gain事件的覆盖的内容中,存在一些本体里声明了,但是十周年UI里没有声明的函数、变量。例如addv、frag1、frag2等,应该并非有意为之,而是错误,只不过因为没有触发一直被掩盖。
建议:
1、如没有必要,可取消覆盖gain事件。
2、如果有必须覆盖实现的效果,弄清楚未声明变量的用途,并添加声明。可以在本体最新的gain事件的基础上重写。

Tipx-L added a commit that referenced this issue Oct 6, 2023
@Tipx-L
Copy link
Owner

Tipx-L commented Oct 6, 2023

现在lib.element.content.gain采用了全新的注入方式,因此不再需要覆盖了。

@Tipx-L Tipx-L closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants