Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧐 Rename VirtualWSIReader Modes #609

Closed
blaginin opened this issue May 17, 2023 · 1 comment · Fixed by #742
Closed

🧐 Rename VirtualWSIReader Modes #609

blaginin opened this issue May 17, 2023 · 1 comment · Fixed by #742
Assignees

Comments

@blaginin
Copy link
Collaborator

  • TIA Toolbox version: 1.4.0

Description

Currently, VirtualWSIReader supports two modes: rgb and bool:

  • However, in reality, bool mode can process single-channel np.uint8 images. Even now, without code modifications, it works fine on matrixes with values other than 0 or 1. uint8 is wider than bool but almost always takes the same amount of memory.
  • If someone uses it with HSV images, it will work just fine, except for the fact that VirtualWSIReader will be called with mode="rgb", which makes no sence.

Let's rename these modes to single channel and multichannel?

@shaneahmed
Copy link
Member

shaneahmed commented May 19, 2023

We would suggest renaming mode="bool" to interpolation_values="discrete" and mode="rgb" to interpolation_values="continuous".

@blaginin Please go ahead and create a PR if you like. Please add deprecation warning, we would change it in remove it in future release.

@shaneahmed shaneahmed changed the title 🧐 rename VirtualWSIReader modes 🧐 Rename VirtualWSIReader Modes May 19, 2023
@shaneahmed shaneahmed linked a pull request Nov 24, 2023 that will close this issue
shaneahmed added a commit that referenced this issue Feb 29, 2024
- Adds support for multichannel inputs e.g., image masks, feature maps etc. Fixes #609 and #610 

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants