Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆕Multichannel Image Reading #825

Draft
wants to merge 58 commits into
base: develop
Choose a base branch
from
Draft

🆕Multichannel Image Reading #825

wants to merge 58 commits into from

Conversation

measty
Copy link
Collaborator

@measty measty commented Jun 21, 2024

Initial draft implementation of multi-channel reading.

multi_channel

Still needs lots of work so its a draft at the moment.

to do:

  • test on other examples
  • unit tests
  • decide what should default behaviour be?
  • decide how will interact with VirtualWSIReader mode flag - should we extend this to all readers?
  • are there better ways to do rgb conversion? simple approach at the moment
  • Get colors from metadata (if existing)
  • Selecting specific channels in viewer
  • anything else?

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 53.15315% with 52 lines in your changes missing coverage. Please review.

Project coverage is 99.29%. Comparing base (14f1215) to head (83c6954).
Report is 4 commits behind head on develop.

Files Patch % Lines
tiatoolbox/wsicore/wsireader.py 50.00% 24 Missing and 20 partials ⚠️
tiatoolbox/utils/postproc_defs.py 61.90% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #825      +/-   ##
===========================================
- Coverage    99.89%   99.29%   -0.61%     
===========================================
  Files           69       70       +1     
  Lines         8650     8737      +87     
  Branches      1653     1686      +33     
===========================================
+ Hits          8641     8675      +34     
- Misses           1       32      +31     
- Partials         8       30      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaneahmed shaneahmed linked an issue Jun 25, 2024 that may be closed by this pull request
@shaneahmed shaneahmed changed the title ENH: initial draft multichannel reading 🆕Multichannel Image Reading Jun 25, 2024
@shaneahmed shaneahmed added the enhancement New feature or request label Jul 8, 2024
measty and others added 28 commits August 7, 2024 15:27
…channel-reading

# Conflicts:
#	tests/test_wsireader.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants