Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🆕 Address TIAViz Review Comments #841

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

🆕 Address TIAViz Review Comments #841

wants to merge 8 commits into from
+52 −5

Conversation

measty
Copy link
Collaborator

@measty measty commented Jul 31, 2024 •
edited
Loading

This PR makes a collection of changes related to reviewer comments in the TIAViz paper, ready for rebuttal.

Main changes are:

  1. Layer names in the interface for static image overlays now are named after filename stem, instead of generic 'layer1', 'layer2' etc to make it easier to distinguish the layers.
  2. Adds multipoint geometry rendering as qupath exports collections of points as multipoints not individual point annotations
  3. Robustifies qupath import from geojson to hand qupath special case of 'nucleusGeometry'

@measty measty marked this pull request as draft July 31, 2024 13:09
@measty measty changed the title address review comments address TIAViz review comments Jul 31, 2024
@shaneahmed shaneahmed changed the title address TIAViz review comments 🆕 Address TIAViz Review Comments Aug 2, 2024
@shaneahmed shaneahmed added this to the Release v1.6.0 milestone Aug 2, 2024
@shaneahmed shaneahmed added the enhancement New feature or request label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@measty measty

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@measty @shaneahmed