Fix the full scene swipe without intercepting touch events #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response, I was away from internet last week. |
artsmvch
force-pushed
the
artsmvch/fix-swipe-to-back
branch
from
d5d36a6 to
3280cea
Compare
|
@Tlaster yep, I fixed the code style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the swipe back gesture is controlled by
SwipeProperties, and the gesture space is set byspaceToSwipe.The problem with the current approach is that all touch events within the
spaceToSwipespace are intercepted. If one needs to enable the full scene swipe (like it's done in Telegram), then none of the elements within the scene will be available for interactaction.This pull request introduces a fix for the full scene swipe without intercepting touch events.
The
spaceToSwipeproperty has also been removed because it is not compatible with the fix and because the swipe-back gesture usually works across the entire scene.