Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scoring #390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix scoring #390

wants to merge 4 commits into from

Conversation

dl1jbe
Copy link
Member

@dl1jbe dl1jbe commented Apr 15, 2023

Rework default scoring.

Drop use of USE_COUNTRYLIST_ONLY and USE_CONTINENTLIST_ONLY from point scoring and replace it by clear precedence rules.

Point scoring is now controlled by the following keyword (in falling order):

  • MY_COUNTRY_POINTS
  • COUNTRY_LIST_POINTS
  • MY_CONTINENT_POINTS
  • CONTINENT_LIST_POINTS
  • DX_POINTS

Keywords not set will be ignored.

Was used for control of point scoring. By leaving all point controlling
keywords (besides COUNTRYLIST_POINTS) undefined the same result can be
achieved.
* Do some further cleanup  and
* adapt test code
@dl1jbe dl1jbe mentioned this pull request Apr 15, 2023
@dl1jbe dl1jbe requested a review from zcsahok April 15, 2023 07:06
src/globalvars.h Outdated Show resolved Hide resolved
@@ -2682,10 +2682,6 @@ instead.
Points for countries in country list.
.
.TP
Copy link
Member

@zcsahok zcsahok Apr 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth spending an own chapter to scoring. At least to have the basic logic documented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Points and multiplier scoring needs to be documented. I was undecided if we do it in man page or should use a separate document. As a start the keywords in man page should be sorted and grouped together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants