Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long long vs int + python 3.11 + spectrally 0.0.4 #964

Merged
merged 41 commits into from
Sep 6, 2024
Merged

Conversation

dvezinet
Copy link
Collaborator

@dvezinet dvezinet commented Sep 5, 2024

Main changes:

Following advice from 6384, all the long types were changed to int64_t / np.int64 in tofu/geom/*.pyx and *.pxd
Unit tests were adapted accordingly

Also, python 3.11 is now supported too.

Issues:

Fixes, in devel, Issue #960

@pep8speaks
Copy link

pep8speaks commented Sep 6, 2024

Hello @dvezinet! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3199:80: E501 line too long (81 > 79 characters)

Line 187:24: E231 missing whitespace after ','
Line 187:29: E231 missing whitespace after ','
Line 412:28: E231 missing whitespace after ','
Line 412:33: E231 missing whitespace after ','

Line 271:80: E501 line too long (83 > 79 characters)
Line 273:80: E501 line too long (89 > 79 characters)
Line 909:17: E225 missing whitespace around operator

Line 376:11: W292 no newline at end of file

Comment last updated at 2024-09-06 03:46:45 UTC

@dvezinet dvezinet changed the title Issue960 long long long long vs int + python 3.11 Sep 6, 2024
@dvezinet dvezinet changed the title long long vs int + python 3.11 long long vs int + python 3.11 + spectrally 0.0.4 Sep 6, 2024
@dvezinet dvezinet merged commit 619d792 into devel Sep 6, 2024
14 checks passed
@dvezinet dvezinet deleted the Issue960_LongLong branch September 6, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants