Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned setuptools version to >=40.8.0, <64 #996

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

Didou09
Copy link
Member

@Didou09 Didou09 commented Dec 3, 2024

Main changes:

  • Pinned setuptools version to >=40.8.0, <64 in:

    • seutp.py
    • requirements.txt
    • pyproject.toml
  • <65 is needed to avoid issues with distutils.msvcompiler

  • <64 is needed to avoid issues with loop import in unit tests

Issues:

Hopefully fixes, in devel, issue #951

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2024

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 141:49: E231 missing whitespace after ':'
Line 149:49: E231 missing whitespace after ':'
Line 153:25: W292 no newline at end of file

Comment last updated at 2024-12-03 16:47:53 UTC

@Didou09 Didou09 changed the title Pinned setuptools version to >=40.8.0, <65.* Pinned setuptools version to >=40.8.0, <65 Dec 3, 2024
@Didou09 Didou09 changed the title Pinned setuptools version to >=40.8.0, <65 Pinned setuptools version to >=40.8.0, <64 Dec 3, 2024
@Didou09 Didou09 merged commit 1e8477c into devel Dec 3, 2024
14 checks passed
@Didou09 Didou09 deleted the Issue951_DistutilsMsvCompiler branch December 3, 2024 17:41
@Didou09 Didou09 mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants